attempt to fix a deploy to an existing project - #1542
Merged
josephjclark merged 2 commits intoSep 11, 2026
Conversation
Collaborator
Author
|
This was breaking locally but I think actually it's just strugglign to dpeloy to the right place The real problem here might be that Idon;t have the target remove available locally. If I fix that I think it'll work |
Collaborator
Author
|
And just seen a problem where I've fetched a project but it overwrite the main alias. I thought I'd fixed that. Never ending pain this project, swear to god |
Collaborator
Author
|
Ok actually my local setup was just broke - it's working fine. One trick: when we do this, the update isn't written to the right local file (the alias is wrong) |
josephjclark
merged commit Sep 11, 2026
d726362
into
checkout-project-yaml-rebase
1 check was pending
josephjclark
added a commit
that referenced
this pull request
Sep 11, 2026
* cli: start ensuring that v2 spec files can be converted to state Several things wrong * project: fix serialisation issue * fixes * remove stray debug console.log calls Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * little refactor * better logging * test: assert credential linkage and edge structure for new-from-spec deploy Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * add test of scenario 1 * Fix an issue where --name is ignored when loading a project from file * ensure cross deployment works from yaml * fix aliases for new projects * fix the alias fix for new projects from checkout * typing * ensure that projects loaded from state files can be loaded statelessly * changeset * fix test * attempt to fix a deploy to an existing project (#1542) * attempt to fix a deploy to an existing project * fix an issue where the wrong alias gets updated * Checkout project v1 (#1546) * support deploying from a v1 spec yaml A v1 spec (as exported from the app) has no uuids and cross-references everything by key, so fromAppState's uuid matching silently mangled it: credentials were dropped and every edge collapsed onto the first job. Convert it to the v2 spec shape instead and let the v2 parser take it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * create to/from-app-spec serializers * tidy * new tests --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using claude to try and fix deploying from a spec file to an existing project.
Two problems here: a dubious divergence test (maybe we should ignore divergence when posting cross-domain?), and then the acutal diff doesn't seem to apply