Repository navigation
Reduce IMU BLE payloads in firmware 2.3.0 - #357
Merged
Merged
Conversation
✅ Unit tests passed4 passed, 0 failed/error, 0 skipped — view workflow run
Download the |
Compiler warningsThe extended-warning build completed successfully. Application compiler warningsShow warnings |
|
Build output available: |
CodeChecker static analysis (advisory)Note This report is informational. It does not block merging and does not change code. At a glance
Findings on changed linesNo non-style findings were reported on lines changed by this PR. Analyzer coverage
Complete-codebase summarySeverity: 2 high, 6 low Complete-codebase findingsEach finding includes source context. The Show detailed findings with source context (8 of 8)HIGH —
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce IMU BLE samples from 36 to 24 bytes: recover the six original int16 accelerometer/gyroscope counts and retain all three calibrated magnetometer floats. The 2.3.x library restores the exact existing float32 values and units. Nine samples fit in one 244-byte notification, up from six.
Acquisition, timestamps, parsing metadata, SD recording, and .oe files keep their existing formats. Encoding rejects values that cannot be reconstructed losslessly. Depends on OpenEarable/protocol#3; stacked on #355 so the firmware version changes with the transport.
Validation: FOTA build passes; seven transport tests pass, including all 65,536 signed counts, unchanged input/SD bytes, batch boundaries and invalid values. Hardware release validation will follow integration.