fix(recording): resume ear streams while the phone is locked - #314
Open
TobiasRoeddiger wants to merge 1 commit into
Open
TobiasRoeddiger wants to merge 1 commit into
TobiasRoeddiger wants to merge 1 commit into
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit f9e0ba5): https://open-earable-web--pr314-codex-recording-back-hc8ae0dl.web.app (expires Fri, 30 Oct 2026 14:35:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c7397c11177c71d8d81172cea9365829823fb41c |
Contributor
PR Build Artifacts
Full workflow run: https://github.com/OpenEarable/app/actions/runs/37020498759 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locking the phone during a local recording stopped automatic reconnect handling. Even after reconnecting, recorder subscriptions waited for a ProxyProvider screen update and resumed only after unlocking.
Keep auto-connect active during recording and register newly connected wearables with the recorder immediately, guarding duplicate connection callbacks. Existing CSV append behavior and the non-recording background path are unchanged.
Verified on the Pixel 9a with both earphones through the real app: reproduced both failures, then disconnected/reconnected each ear while locked. All 16 exported sensor CSVs retained earlier samples and resumed collecting while still locked, before any sensor reconfiguration. All 99 Flutter tests, analysis, and the Android release build passed.
Addresses OpenEarable/open-earable-2#327 item 2.