Repository navigation
fix: sort sensor sampling rates numerically - #312
Merged
TobiasRoeddiger merged 1 commit intoOct 4, 2026
Merged
TobiasRoeddiger merged 1 commit into
TobiasRoeddiger merged 1 commit into
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit 4d34a93): https://open-earable-web--pr312-codex-sort-ppg-sampl-pgqippx3.web.app (expires Fri, 30 Oct 2026 12:15:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c7397c11177c71d8d81172cea9365829823fb41c |
Contributor
PR Build Artifacts
Full workflow run: https://github.com/OpenEarable/app/actions/runs/37005326126 |
TobiasRoeddiger
merged commit Oct 4, 2026
0b5fc56
into
automation/bump-version-1.5.4-36858743484
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PPG rates currently appear in firmware order (25, 50, 84, …, 8, 16, …). Sort frequency dropdown options numerically in the app, after filtering for the selected data targets.
Only the displayed list is sorted; each option retains its original configuration object and firmware mapping. Non-frequency options keep their existing order. Targets 1.5.4; works with both firmware 2.2.9 and 2.2.10.
Validation: formatting and
flutter analyze --no-pubpass; all 99 existing tests pass (flutter test --no-pub). Not tested on the phone.