Repository navigation
Share sensor configuration reports with network clients - #309
Merged
TobiasRoeddiger merged 2 commits intoOct 2, 2026
Merged
TobiasRoeddiger merged 2 commits into
TobiasRoeddiger merged 2 commits into
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit ce4ec22): https://open-earable-web--pr309-codex-shared-sensor-giumzbcn.web.app (expires Fri, 30 Oct 2026 10:01:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c7397c11177c71d8d81172cea9365829823fb41c |
Contributor
PR Build Artifacts
Full workflow run: https://github.com/OpenEarable/app/actions/runs/36992788497 |
TobiasRoeddiger
merged commit Oct 2, 2026
63da401
into
automation/bump-version-1.5.4-36858743484
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share one sensor-configuration subscription per device between the UI and network clients. The library creates a new BLE subscription on each getter call, which previously canceled another consumer's subscription. Replay the latest report to new listeners and release BLE when the last listener leaves.
Verified: sharing/replay/cancellation/error tests and existing provider test; Android release build; two real network clients received changes together. Canceling one preserved the other, and after both unsubscribed the phone UI still updated to the hardware-reported 200 Hz setting. Returned the sensor to Off.
Addresses OpenEarable/open-earable-2#327, item 12.