Repository navigation
Handle development versions in firmware update checks - #307
Merged
TobiasRoeddiger merged 3 commits intoOct 2, 2026
Merged
TobiasRoeddiger merged 3 commits into
TobiasRoeddiger merged 3 commits into
Conversation
Contributor
PR Build Artifacts
Full workflow run: https://github.com/OpenEarable/app/actions/runs/36994921303 |
Contributor
|
Visit the preview URL for this PR (updated for commit 884bf9d): https://open-earable-web--pr307-codex-firmware-prere-i82cy9mh.web.app (expires Fri, 30 Oct 2026 10:23:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c7397c11177c71d8d81172cea9365829823fb41c |
TobiasRoeddiger
merged commit Oct 2, 2026
cc891da
into
automation/bump-version-1.5.4-36858743484
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the automatic firmware update check for versions such as
2.2.10-dev.60+ga99d057fa. Compare semantic versions, including prerelease precedence, while ignoring build metadata and transport padding. Unrecognized labels still fail explicitly instead of suggesting a downgrade.Verified: three regression tests; Android release build; the real app successfully checked both connected earphones' development versions without a parsing error.
Addresses OpenEarable/open-earable-2#327, item 23.