Repository navigation
ci: sync uv.lock on release-please PRs - #39
Merged
Merged
Conversation
release-please bumps pyproject.toml but not uv.lock, leaving the lock one version behind after every release. Regenerate it on the release PR branch (ported from py-opendisplay). Also syncs the stale lock to 0.5.12.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Step env is resolved before the step if, so fromJSON(steps.release.outputs.pr) failed on empty output whenever release-please had nothing to do. Read the branch only in the checkout step and push to HEAD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please bumps the version in
pyproject.tomlbut not inuv.lock, which records the project's own version. After every release the lock file is one version behind. Each lateruv run, including the pre-commit hooks, then rewrites it, which dirties the tree and can block commits.This adds the lock-file sync step from py-opendisplay's release workflow. When release-please opens or updates a release PR, CI checks out that PR's branch, runs
uv lock, and pushesuv.lockif it changed. It is safe to run repeatedly.One change from py-opendisplay: the branch name comes from release-please's
proutput (fromJSON(steps.release.outputs.pr).headBranchName) instead of being hardcoded. This repo's release branch isrelease-please--branches--main--components--odl-renderer, so the hardcodedrelease-please--branches--mainwould miss it.This PR also commits the stale lock file (
0.5.11→0.5.12).Test plan
chore: sync uv.lock with release versioncommit is added