Repository navigation
feat!: testing for actions PR 51 - #14
Open
seantronsen wants to merge 3 commits into
Open
seantronsen wants to merge 3 commits into
seantronsen wants to merge 3 commits into
Conversation
Open
10 of 17 tasks
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
seantronsen
force-pushed
the
seantronsen/fabrica-testing
branch
from
October 20, 2026 17:06
bf51b36 to
5a999e1
Compare
seantronsen
marked this pull request as ready for review
October 20, 2026 17:07
11 of 17 tasks
synackd
requested changes
Oct 27, 2026
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
seantronsen
force-pushed
the
seantronsen/fabrica-testing
branch
from
October 27, 2026 16:53
95d46d8 to
5fef860
Compare
|
I see we test the happy path. Do we test that code drift causes this to fail anywhere? |
Collaborator
Author
The recent commit 1af3ff2 will test this explicitly and be dropped after. |
seantronsen
force-pushed
the
seantronsen/fabrica-testing
branch
2 times, most recently
from
November 2, 2026 21:54
1af3ff2 to
5fef860
Compare
Collaborator
Author
|
CI is busted up because all the rebase shenanigans which changed all the sha pins. I'll update this whole sale later so each occurs at the correct position in the stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
lint-makefile-commonfails until v4.0 is released (see #11).Testbed for OpenCHAMI/github-actions#51. Converts the testbed into a minimal Fabrica project, so it can test the Fabrica code generation checks: the
lint-codegen-fabricaworkflow (OpenCHAMI/github-actions#39) and thegenerate/generate-checktargets in Makefile.common (OpenCHAMI/github-actions#48).Widgetresource and file storage. The generated code is in its own commit, separate from the files written by hand.testbedbinary is now the Fabrica server (./cmd/server, withserveas the image's default command). It replacescmd/testbed. Release outputs and package contents are unchanged.lint.yml: addslint-codegen-fabricato thelintgate, pinned to the fix(workflows): step 9, keep the Fabrica checkout out of generate-check github-actions#51 head.go 1.26.10: Fabrica requires at least 1.26.6, which has a standard-library vulnerability reachable from our code (GO-2026-6617).Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change