Repository navigation
fix(security): omit WireGuard private key from startup logs - #143
Closed
alexlovelltroy wants to merge 1 commit into
Closed
alexlovelltroy wants to merge 1 commit into
alexlovelltroy wants to merge 1 commit into
Conversation
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
alexlovelltroy
marked this pull request as draft
November 6, 2026 16:06
Member
Author
|
Marked as draft as there's one more change I want to add which better protects admin routes. |
Contributor
|
Sounds good. Go ahead and request my review once ready. |
Member
Author
|
#144 replaces this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the security of WireGuard startup diagnostics by ensuring that the server's private key is no longer logged at INFO or DEBUG levels. It updates documentation, removes sensitive logging, and adds a test to verify that private keys are never written to logs while maintaining useful diagnostics.
Security and Logging Improvements:
StartServer, ensuring that only non-sensitive information (interface name, public key, listen port, IP address) is logged.TestStartServerDoesNotLogPrivateKey, instartup_logging_test.goto verify that the private key is never logged and that useful public diagnostics are present.Documentation Updates:
docs/security-logging.mddescribing the change, its impact, and clarifying that no configuration or client migration is required.Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change