Skip to content

GCMC region methods fail on OpenCL and without a region #38

Description

@lohedges

delete_waters() and num_waters() upload the GCMC sphere centre to the GPU twice. CUDA tolerates this, but OpenCL raises TypeError: a bytes-like object is required, not 'Array', so both methods fail there. Neither was covered on that platform: loch's OpenCL tests only exercise move().

Separately, delete_waters() raises AttributeError on _reference_indices when no GCMC region is defined, which is the same problem fixed for num_waters() in #36.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions