Repository navigation
feat: add a redis chart for DSS form sessions and wire DSS_REDIS_URL - #136
Merged
Merged
Conversation
…/engineering-tracker#207] One Redis pod for decision-support-system's form-session state (DSS ADR-0022): password from an existing Secret, nothing saved to disk, no volume, restarts empty. Kubernetes restarting the pod is the failover; no replication, Sentinel or operator in this first pass. No TLS.
RohanReddy44
force-pushed
the
feat/207-redis-chart
branch
from
November 16, 2026 08:26
6573d93 to
77d4166
Compare
…penAgriNet/engineering-tracker#207] decision-support-system 0.3.0: - redis.urlSecret.{name,key,optional} renders DSS_REDIS_URL from a Secret. optional lets the pod start while the Secret is still missing, as if unset. - README and description: form sessions and their cross-replica lock live in Redis; the DSS is no longer described as stateless without qualification. redis (unreleased 0.1.0): - NetworkPolicy, on by default: only DSS pods may connect on 6379. The render fails if it is on with no peers. - The password never goes on a command line: the server reads it as config on stdin, redis-cli reads REDISCLI_AUTH. - Liveness waits for six misses before a restart, which empties the store. - README and example use the dss namespace, the FQDN URL, redis.urlSecret, and document rotation (restart redis and the DSS together).
tarannum-2002
approved these changes
Nov 17, 2026
| urlSecret: | ||
| name: dss-redis | ||
| key: url | ||
| optional: true |
Author
There was a problem hiding this comment.
for now yes
but eventually once I refactor DSS to always expect redis, I will switch it to False
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
redischart: one Redis pod, password required, in memory only. Built fromtemplateoncommon, likeqdrantandminio.decision-support-system0.3.0:redis.urlSecret.{name,key,optional}rendersDSS_REDIS_URLfrom a Secret.Why
DSS_REDIS_URL). Without one, a form that needs an OTP cannot finish.The redis chart
requirepass,--save "",--appendonly no. Adds--maxmemory 100mbandallkeys-lru, so Redis evicts instead of being OOM-killed.Recreate. Failover is Kubernetes restarting the pod. No replication, Sentinel or operator in this first pass.auth.existingSecret). The chart renders no Secret and refuses to render without one.redis-cli(probes,kubectl exec) readsREDISCLI_AUTH.ClusterIPonly, no Ingress.redisuser (uid 999, gid 1000), all capabilities dropped, no service-account token.The DSS chart (0.3.0)
redis.urlSecret: {name, key: url, optional: false}renders asecretKeyRefforDSS_REDIS_URL. Off by default.optional: truelets the pod start while the Secret is still missing, the same as no store.Testing
helm lint --strictpasses on Helm v3.16.4 (the CI version) for every CI values file of both charts.auth.existingSecretfails; NetworkPolicy on with no peers fails;urlSecret.namewithout akeyfails.manage-secrets.pyand delivered through OpenBao, ESO and Reflector.redis-cli pingworks viaREDISCLI_AUTH; with no password it getsNOAUTH; PID 1's command line shows no password.v0.2.0:DSS_REDIS_URLcomes from the Secret, and the image's redis-py pings and sets/gets through it.optional: truewith a missing Secret: the pod starts andDSS_REDIS_URLis unset. Withoutoptional:CreateContainerConfigError.Open
appVersionchange.Relates to OpenAgriNet/engineering-tracker#207