Repository navigation
fix(langfuse): name the MinIO container minio, not its alias - #133
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Inside the langfuse chart, MinIO's container is now named
minio, and its labels sayminioinstead ofobjectStorage. Chart 3.0.0 to 3.0.1.Why
Under the alias
objectStorage, Helm gives the subchart that name, and the MinIO template used it for the container. Container names must be lowercase, so Kubernetes refused the Deployment:On dev, Langfuse is stuck OutOfSync and Missing because of it, and has no object storage.
Testing
minio, its labels sayminio, and no container in the chart has an invalid name.scripts/lint-charts.sh langfuse: langfuse lints clean. The run also lints cert-manager, which fails the same way ondevelopmentwithout this change.Relates to OpenAgriNet/engineering-tracker#235