Repository navigation
refactor: remove the stub layer; always call the Experience API [#212] - #28
Merged
Merged
Conversation
- A stubbed reply could pass for a real answer, and a stubbed form was never filed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The client has no stubs any more.
src/lib/api-stubs.ts, its test and thestubsblock inconfig.jsonare gone. Chat always calls the Experience API. Image upload, suggestions, voice and spoken answers call their real endpoints too; they stay switched off by their flags.Docs updated: README, CLAUDE.md and ADR-0000 §6 (amended: a flag is enough for a surface with nothing behind it). A stale comment that said the API does not carry forms is fixed.
Why
A canned reply could be taken for real advice, and a form sent to a stub was never filed. The Experience API now drops its fake DSS too (experience-api #10), so every reply comes from the DSS.
With no API running, every question now shows an error card. To try the chat, run the DSS, then the Experience API.
Testing
Run locally:
npm run lint,npm run typecheck,npm run knip(all clean),npm test(96 passed),npm run build(built,routeTree.gen.tsunchanged). Not checked innpm run dev.Relates to OpenAgriNet/engineering-tracker#212
🤖 Generated with Claude Code