Skip to content

fix(compose): give the XTM One worker its public URL and accept OpenAEV's internal audience (#166) - #167

Merged
Samuel Hassine (SamuelHassine) merged 2 commits into
masterfrom
fix/xtm-one-internal-urls-166
Sep 29, 2026
Merged

Samuel Hassine (SamuelHassine) merged 2 commits into
masterfrom
fix/xtm-one-internal-urls-166

Conversation

@SamuelHassine

Copy link
Copy Markdown
Member

Summary

OpenAEV registered with XTM One in this stack, but the signed calls between them were refused with 401. The root cause is in the products and is fixed there (XTM-One-Platform/xtm-one#4883, OpenAEV-Platform/openaev#8143); this PR fixes what the stack itself got wrong and documents the URLs, without changing any default.

  • xtm-one-worker gets the same BASE_URL / FRONTEND_URL as xtm-one. Without it the worker signed the tokens of background work (assignments, autonomous runs) with XTM One's built-in default issuer, https://copilot.filigran.ai, which OpenAEV can never trust.
  • xtm-one sets XTM_AUTH_ACCEPTED_AUDIENCES=http://xtm-one:4000: OpenAEV versions that predate fix(xtm-one): trust and address XTM One by its published identity when it is reached on an internal URL (#8142) openaev#8143 address their tokens to OPENAEV_XTM_ONE_URL, and XTM One accepts that as its own audience once told so. XTM One images that predate the variable ignore it.
  • README ("Public and internal URLs") and .env.sample explain which URL users open, which one each product signs with, and which one the containers use.
  • The localhost defaults, ports and service names are unchanged.

Test plan

  • docker compose -f docker-compose.yml --env-file .env.sample config -q.
  • With the XTM One and OpenAEV fixes released: docker compose up, then an Ask Ariane question that reads OpenAEV data, and an autonomous run (worker path and callbacks).

Closes #166

…EV's internal audience (#166)

The worker signed the tokens of background work with XTM One's built-in default issuer, which OpenAEV never trusts. XTM One now also accepts http://xtm-one:4000 as the audience of OpenAEV's tokens, for OpenAEV versions that address them to the internal URL. The README and .env.sample explain the public and internal URLs.
Copilot AI balanced review requested due to automatic review settings September 29, 2026 12:54
@SamuelHassine Samuel Hassine (SamuelHassine) added the vibe-coded PR: AI-assisted change — the author reviews it before requesting others' review. label Sep 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The URL documentation omits required scheme variables and references issue reports instead of the implementation PRs.

Review effort: Balanced
Findings: 2 Low severity

Open (2)
What changed in this PR

Configures reliable signed communication between XTM One and OpenAEV while documenting public and internal URLs.

Changes:

  • Configures the worker’s public URL.
  • Accepts OpenAEV’s internal audience.
  • Documents URL configuration and troubleshooting.
File Description
docker-compose.yml Adds worker URLs and accepted audience.
.env.sample Documents public host identities.
README.md Explains URL roles and troubleshooting.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md Outdated
Comment thread README.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

End-to-end authentication depends on unreleased external changes, and the integration test remains pending.

Review effort: Balanced
Findings: None

Resolved since last review (2)

@SamuelHassine
Samuel Hassine (SamuelHassine) merged commit eb4c9da into master Sep 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vibe-coded PR: AI-assisted change — the author reviews it before requesting others' review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(compose): give the XTM One worker its public URL and accept OpenAEV's internal audience

2 participants