Add tests for legacy momentum signal wrapper - #40
Merged
Merged
Conversation
src/strategies/momentum.py (the backward-compatible create_momentum_signals wrapper) had 0% test coverage. Added tests covering Series/DataFrame input, boolean/mutually-exclusive entries-exits, custom window params, and a flat-price no-signal case. Bumps test count badge from 191 to 196.
Owner
Author
|
CI is currently red on the Test Suite jobs (Python 3.10, 3.11, 3.12). All three fail at the same
I'm holding off on pushing a fix for the unused-import lint failure. My task instructions for this PR explicitly said not to push new commits or amend the existing one unless I stop and report back first, so I'm flagging this here rather than fixing it myself. The one-line fix is to drop the unused Generated by Claude Code Generated by Claude Code |
OnePunchMonk
added a commit
that referenced
this pull request
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for the backward-compatible wrapper
create_momentum_signalsinsrc/strategies/momentum.py. This function previously had 0% test coverage.The new test file
tests/test_momentum_legacy.pycovers the following cases.The README test count badge is bumped from 191 to 196 to match the new total.
Ran the full suite locally with
pytest tests/ -q. All 196 tests pass.Generated by Claude Code