Repository navigation
Pin fixed Guava and OpenTelemetry in build and fixture graphs - #269
Merged
Merged
Conversation
GHSA-xxph-c9ww-hj94 affects Guava through 33.7.1 and GHSA-ccrj-gw8r-854m affects OpenTelemetry Java through 1.66.0. Both reached the repository only through build-plugin realms and the unpublished Jakarta fixture's Selenium test classpath. Pin Guava 33.7.2-jre in the Checkstyle, japicmp (exec), WAR and Central publisher plugin realms and in the fixture's dependency management, and raise the fixture's Boot-managed OpenTelemetry BOM to 1.67.0. Selenium stays on 4.49.0 to match the digest-pinned browser image. Published library dependencies are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot has six open alerts: five for Guava (GHSA-xxph-c9ww-hj94, fixed in 33.7.2) and one for OpenTelemetry Java (GHSA-ccrj-gw8r-854m, fixed in 1.67.0). None of them touch a published library dependency. They come from build-plugin realms and the unpublished Jakarta fixture's Selenium test classpath.
Guava 33.7.2-jre pins, following the existing plugin-realm pattern:
exec-maven-pluginbrings 33.4.8central-publishing-maven-pluginbrings 32.1.0. The pin sits in plugin management, so the release profile's existing publisher pins still merge with it.OpenTelemetry: Boot 4.1.2 manages the BOM at 1.62.0. The fixture's
opentelemetry.versionproperty now raises it to 1.67.0.Selenium stays on 4.49.0 so the client matches the digest-pinned browser image. Selenium 4.52.0 already carries both fixes, so a later reviewed client-and-image update can drop the fixture pins. The decision record covers this and the removal conditions.
Verification
dependency:resolve-plugins: every executed realm in the default,testJakartaandsign-artifactsprofiles resolves Guava 33.7.2, both on main and merged with Bump the maven-dependencies group across 1 directory with 11 updates #266 (exec-maven-plugin 3.7.0). That merge is clean. The fixture test tree resolves Guava 33.7.2 and OpenTelemetry 1.67.0../mvnw verifyon JDK 17 passes, with Checkstyle and japicmp running on the new Guava.testJakartapackage passes, running the WAR and fixture Checkstyle realms. The policy unit tests pass.