Skip to content

Fix OWASP importer hyperlinks - #1105

Open
Bornunique911 wants to merge 2 commits into
OWASP:mainfrom
Bornunique911:importers-links-fixes
Open

Fix OWASP importer hyperlinks#1105
Bornunique911 wants to merge 2 commits into
OWASP:mainfrom
Bornunique911:importers-links-fixes

Conversation

@Bornunique911

@Bornunique911 Bornunique911 commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Update OWASP mapping fixture URLs to their current dedicated domains and align the parser test expectation.

Problem

Several importer hyperlinks still pointed to outdated owasp.org paths, resulting in incorrect or inaccessible links in imported mappings.

Solution

Replace legacy URLs with the current OWASP domains for API Security, Kubernetes Top 10, and OWASP Top 10 2025. Update the corresponding parser test assertion.

Files Changed

application/tests/fixtures/owasp_mappings/owasp_api_top10_2023.json
application/tests/fixtures/owasp_mappings/owasp_kubernetes_top10_2022.json
application/tests/fixtures/owasp_mappings/owasp_kubernetes_top10_2025.json
application/tests/fixtures/owasp_mappings/owasp_top10_2025.json
application/tests/owasp_top10_2025_parser_test.py

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: 451d1068-deee-4a25-bfa8-9eebe08f6ae5

📥 Commits

Reviewing files that changed from the base of the PR and between 38db0c0 and f72815d.

📒 Files selected for processing (5)
  • application/tests/fixtures/owasp_mappings/owasp_api_top10_2023.json
  • application/tests/fixtures/owasp_mappings/owasp_kubernetes_top10_2022.json
  • application/tests/fixtures/owasp_mappings/owasp_kubernetes_top10_2025.json
  • application/tests/fixtures/owasp_mappings/owasp_top10_2025.json
  • application/tests/owasp_top10_2025_parser_test.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Summary by CodeRabbit

  • Bug Fixes
    • Updated OWASP reference links for API, Kubernetes, and general Top 10 mappings to their current official domains.
    • Corrected the expected OWASP Top 10 2025 parser link to match the updated reference URL.

Walkthrough

The change updates OWASP hyperlink domains in four mapping fixtures and aligns the OWASP Top 10 2025 parser test with the new A01 URL.

Changes

OWASP link updates

Layer / File(s) Summary
Update OWASP mapping URLs
application/tests/fixtures/owasp_mappings/*.json
The API, Kubernetes, and OWASP Top 10 fixtures now use updated hyperlink domains. Section identifiers, names, paths, and CRE mappings remain unchanged.
Align parser test expectation
application/tests/owasp_top10_2025_parser_test.py
The expected A01 hyperlink now uses the top10.owasp.org domain.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f7281

This PR updates OWASP reference URLs and keeps the parser expectation aligned, with no identified behavior or data risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (4 skipped: 4 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: updating OWASP importer hyperlinks.
Description check ✅ Passed The description accurately explains the outdated OWASP URLs, the replacement domains, and the related parser test update.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (4 skipped: 4 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant