Repository navigation
HDXDSYS-3021 Upgrade ruff, pre-commit hooks and GitHub Actions; fix new lint violations - #128
Merged
Merged
Conversation
…violations - actions/checkout v7.0.1, astral-sh/setup-uv v10.3.2 - ruff 0.17.3, uv-pre-commit 0.13.6 - hdx-python-utilities >= 4.2.6 - Fix violations from ruff 0.17's expanded default rules - Default today to None instead of now_utc() evaluated at import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bumps
actions/checkoutastral-sh/setup-uvruff(pre-commit and dev dependency)uv-pre-commithdx-python-utilitiesminimumuv.lockupgraded. The setup-uv v10 and checkout v7 breaking changes only affectpull_request_target,workflow_runandreleasecaching/fork checkout, which these workflows don't rely on.Lint fixes
Ruff 0.17 expanded its default rule set, which raised 102 violations.
tool.ruffis unchanged; the code was fixed instead:if/with, mergedisinstancecalls, explicitX | NoneforNonedefaults,Noneinstead of mutable default arguments inDataset.reviseClassVarannotations on class-level dicts/listssuppress(HDXError)instead ofexcept Exception: passinLocation/Organization(_write_to_hdxwraps all errors inHDXError).pyfiles without shebangsBug fix
today: datetime = now_utc()inDateHelper.get_time_period_info,Dataset.get_time_periodandResource.get_date_of_resourcewas evaluated once at import, so long-running processes used a stale date. These now default toNoneand callnow_utc()at call time.