Repository navigation
[FW] [FIX] base_geoengine: Fix Vector Layer related Error - #476
Merged
Merged
Conversation
anusriNPS
force-pushed
the
18.0-fix-geoview
branch
from
August 14, 2026 14:10
ed12a8c to
34d1e3c
Compare
anusriNPS
changed the title
anusriNPS
marked this pull request as draft
September 14, 2026 07:32
anusriNPS
force-pushed
the
18.0-fix-geoview
branch
2 times, most recently
from
September 15, 2026 05:00
8233c79 to
33e629f
Compare
anusriNPS
marked this pull request as ready for review
September 16, 2026 03:49
anusriNPS
force-pushed
the
18.0-fix-geoview
branch
from
September 16, 2026 05:21
33e629f to
74439eb
Compare
Author
|
max3903
changed the title
anusriNPS
changed the title
Notifying user to define selected attribute_field_id of supported type from vector layer as part of geoengine view xml defintion which avoids observed JS error.
Updated checkAttributeFieldUsage method in order to handle a vector layer which does not contain attribute_field_id value as the field attribute_field_id is optional for basic representation mode in geoengine view.
anusriNPS
force-pushed
the
18.0-fix-geoview
branch
from
October 6, 2026 05:48
74439eb to
e628a81
Compare
Author
max3903
approved these changes
Oct 6, 2026
Member
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at c93987b. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FW #417
JS Error is not observed in 18.0. Porting the changes as notifying the users is useful when attributes selected in vector layer is not defined in geoengine view templates