Repository navigation
Conversation
bvolpato
marked this pull request as ready for review
August 3, 2026 19:37
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dependency versions in pyproject.toml and docker/pyproject.amd.toml. Specifically, it upgrades transformers to version 5.11.0 (pinning it and removing platform restrictions in overrides) and updates peft from 0.18.1 to 0.19.1 across dependencies and training extras. There are no review comments, so I have no feedback to provide.
This was referenced Aug 3, 2026
bvolpato
force-pushed
the
bvolpato/transformers-5-11
branch
from
August 4, 2026 00:37
44eeae4 to
87ab3cb
Compare
bvolpato
force-pushed
the
bvolpato/transformers-5-11
branch
3 times, most recently
from
August 16, 2026 15:31
13334fc to
61c5469
Compare
bvolpato
force-pushed
the
bvolpato/transformers-5-11
branch
from
August 21, 2026 00:56
61c5469 to
4bcab05
Compare
bvolpato
force-pushed
the
bvolpato/transformers-5-11
branch
2 times, most recently
from
September 2, 2026 06:22
78a703a to
1c82a8b
Compare
bvolpato
force-pushed
the
bvolpato/transformers-5-11
branch
from
September 9, 2026 13:38
1c82a8b to
386d502
Compare
Pin Transformers 5.11.0, first tested release accepting deepseek_sparse_attention layer types. Update PEFT for compatible adapter APIs and apply Transformers override on every platform. Signed-off-by: bvolpato <brunocvcunha@gmail.com>
Signed-off-by: bvolpato <brunocvcunha@gmail.com>
bvolpato
force-pushed
the
bvolpato/transformers-5-11
branch
from
September 12, 2026 18:21
386d502 to
21765af
Compare
bvolpato
force-pushed
the
bvolpato/transformers-5-11
branch
from
October 8, 2026 23:54
cdbbe80 to
0101bea
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add GLM-5.2 configuration support by pinning the first tested Transformers release that accepts its
deepseek_sparse_attentionlayer type. Update PEFT and make FSDP adapter configuration serialization handle every set and enum field exposed by the newer release.Changes
Version choice
Transformers 5.8.0 through 5.10.0 reject the 0.8B GLM-5.2 config. Versions 5.13.0 and 5.14.1 conflict with pinned Megatron Bridge through duplicate
qwen3_asrregistration, while 5.12.0 exposes a Torch/TorchAudio CUDA wheel mismatch during eager audio import. Version 5.11.0 loadsGlmMoeDsaConfigwithout rewriting model configuration or expanding this PR into those separate dependency changes.Validation
uv lock --checkand full pre-commit360 passed); two Qwen VLM processor cases were omitted becausetorchvisionis not part of selected CPU test extrasGlmMoeDsaConfigload forinference-optimization/GLM-5.2-0.8B-A0.8B26 passed)1395 passed, 5 skipped, 5 deselected)12.4402to11.9881)Local GLM rollout used a test-only dense MLA fallback because current sparse MLA kernels reject this checkpoint's 192-wide compressed KV head on SM120. Native long-context DSA and Megatron GLM-5.2 support remain outside scope. AMD and Megatron GPU runs were not available locally.
Note
Medium Risk
Changes the PEFT pin and how adapter configs are written during FSDP checkpointing and vLLM LoRA sync; incorrect serialization would break adapter reload, though behavior is covered by a focused test.
Overview
Bumps PEFT from
0.18.1to0.19.1in the root and AMDpyprojectfiles and refreshesuv.lock.Adds
serialize_peft_configinfsdp_utilsso LoRAadapter_config.jsonis JSON-safe under newer PEFT configs (recursive handling of enums, sets, and nested structures). FSDP checkpoint saves and inference LoRA hot-sync now call this helper instead of ad-hocasdictplus manualtask_type/peft_type/target_modulesfixes.Includes a unit test that
LoraConfigwith enums and module lists round-trips throughjson.dumps.Reviewed by Cursor Bugbot for commit 0101bea. Bugbot is set up for automated code reviews on this repo. Configure here.