Repository navigation
docs(cpctl): drop cpctl config from the command set - #311
Merged
Merged
Conversation
cpctl info already returns config_path and working_dir, so callers read the config file themselves. Move the command to the dropped list (section 7.4) and renumber reload to 6.4. State in section 5.3 that an unknown subcommand is reported in text format: cobra rejects it before --format is parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docs/REFACTOR-CPCTL.md§6 and §6.4 specifycpctl config, but cpctl does not implement it. The doc also says every stderr line under-f jsonlis a JSON object, while an unknown subcommand is reported in text format.Change
cpctl configfrom the §6 command list and delete §6.4.cpctl infoalready returnsconfig_pathandworking_dir, so callers read the config file themselves. The command moves to the dropped list as §7.4, with that reason. §6.5 reload becomes §6.4.cpctl configmention from the §10 table.--formatis parsed, so it is printed in text format and cpctl exits 1. The doc now says so; no code change.Fixes #298