Repository navigation
ci: add GitHub Actions workflow (test, clippy, release build) - #39
Merged
Merged
Conversation
Adds CI for the neodev crate itself: - Test: cargo test --locked - Clippy: cargo clippy --all-targets --locked -- -D warnings - Build: cargo build --release --locked Also fixes the five clippy warnings that would have failed the new gate: unused UNIX_EPOCH import, manual div_ceil, needless borrow, needless range loop, and a complex tuple type in image.rs factored into FreeRegion / FreelistPlan aliases. cargo fmt --check is not gated yet: 262 diff hunks need their own sweep. Closes #38
test_detect_returns_real_ethernet asserted `selected != "eth0"`, which fails on hosts where the live interface is itself named eth0 -- GitHub Actions runners included. The CI added in this PR caught it on its first run. Assert instead that detection picks one of the live interfaces the test found (mirroring detect_bridge_interface's exclusions), which is what the test actually means. Refs #38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38 (IMP-15).
Summary
First CI for the
neodevcrate itself. Three jobs onubuntu-latest, stable Rust,Swatinem/rust-cache:cargo test --lockedcargo clippy --all-targets --locked -- -D warningscargo build --release --lockedTriggers: PRs to
main, pushes tomain.permissions: contents: readand a cancel-in-progress concurrency group.Verified locally
The 5 clippy warnings that would have broken the new gate are fixed:
std::time::UNIX_EPOCHimport (vmm/vbox.rs)div_ceil→len().div_ceil(REGIONS_PER_NODE)(image.rs)std::fs::read_dir(root)(image.rs)nodes.iter().take(chunks.len())(image.rstest)FreeRegion/FreelistPlantype aliases (image.rs)Not gated yet
cargo fmt --check:cargo fmt --all -- --checkcurrently reports 262 diff hunks acrossmain. Formatting the whole crate is a separate, mechanical PR; gating it now would make this one red on arrival.Notes
CONTRIBUTING.mdsays to branch and open PRs againstdevelop, but the repository's branch ismain. Left untouched here (docs drift); happy to fix it separately.