fix: the daemon's git runs no hooks, a stale worktree is cut again, and a long reason no longer widens its card - #95
Merged
Merged
Conversation
…nd a long reason no longer widens its card A checkout's hook scripts are the pull request author's code, and the daemon runs with the reviewer's credentials: husky's post-checkout in a checkout ran pnpm install and pnpm build on every worktree add, slowly, sometimes failing, and with everything the agent is denied. Every git call the daemon makes now runs with core.hooksPath pointed at nothing. A worktree directory whose registration in the clone is gone is deleted and cut again instead of failing on checkout, and removeWorktree deletes the directory whatever git made of it and prunes. On the page, a card inside a flex row could grow with its status reason; it keeps its width now, and the full reason is on hover. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
A directory with a .git directory is a repository of its own — the clone, or whatever a misconfigured worktreesDir points at — and is refused; only a .git file or none is disposable. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things the inbox page showed this morning.
core.hooksPath=.husky/_, and itspost-checkoutrunspnpm install --frozen-lockfileandpnpm build. Everygit worktree addandcheckoutthe daemon made ran that script — slowly, sometimes failing ("Command failed: git worktree add … Preparing worktree … Packages are hard linked …"), and with the reviewer's full environment, which is exactly what the review agent is denied. The hook script is part of the checked-out tree, so it is the pull request author's code. Every git call inworktree.tsnow runs withcore.hooksPath=/dev/nullandGIT_TERMINAL_PROMPT=0. A test wires a marking hook the way husky does, confirms a plain checkout runs it, and confirmsprepareWorktreedoes not..gitfile pointing at a registration the clone no longer had, so the "existing worktree" path failed on checkout every tick. That path now falls back to removing and cutting again;removeWorktreedeletes the directory whatever git made of it and prunes, so a leftover directory never blocksaddagain..entryhadmin-width: auto, so a long status reason grew it past the page.min-width: 0keeps it in the card; the full reason, wrapped, is on hover.Bumps to 0.10.21.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w