Repository navigation
Conversation
…d drags For NativePHP/mobile-air#716 and NativePHP/mobile-ui#220. The props, events and the Zoomable images example now use zoom, zoom-min, zoom-max and @zoomEnd. The zoom prop says once that the pinch names still work. Zoomable images gets three new parts. Double tap to zoom covers @doubleTap.zoom and what an @event.modifier value means. Who gets a drag explains when a bounded area takes a drag and when it leaves it to a pager, scroll view or drag to close, including the hand-off at the edge. A photo viewer puts them together in a pager. Its bullet list also gains the glide on release, where @Dragend reports, and clipping. The gestures guide links to the section. The new labels say 4.9 and mobile-ui 0.11. Neither is in config/docs.php yet, so the version label test fails until they ship, as it does on #601. The Events list conflicts with #601 in one hunk: its @trigger entry and this PR's @zoomEnd both sit right after @Dragend. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the gesture area changes in NativePHP/mobile-air#716 and NativePHP/mobile-ui#220. Merge once both have shipped.
On the gesture area page:
zoom,zoom-min,zoom-maxand@zoomEndare now the names used everywhere, with one note that thepinchnames still work.@doubleTap.zoomentry and a "Double tap to zoom" section, which also explains that@event.modifier="value"passes a value to the phone instead of calling a component method.The gestures guide gets one short paragraph pointing at Zoomable images.
Things to check before merging:
VersionBadgeTestfails becauseconfig/docs.phpdoesn't list those versions yet. Document the gesture area's trigger-x, trigger-y and @trigger #601 has the same failure for 4.8 and 0.10, which are out now.@dragEndtext and its@triggerentry, then this branch's@zoomEndand@doubleTap.zoom, then@swipe.zoom($target, $scale), since mobile-air#716 makes that the main name and keepspinch()working.🤖 Generated with Claude Code