Repository navigation
[Guilds 01] Browse guilds, and show which guild a commit was posted in - #188
Draft
shanesmithdev wants to merge 2 commits into
Draft
shanesmithdev wants to merge 2 commits into
shanesmithdev wants to merge 2 commits into
Conversation
Contributor
Author
|
FYI @simonhamp |
shanesmithdev
marked this pull request as draft
November 20, 2026 10:30
Contributor
Author
|
Found a small oversight. Converted to draft temporarily while I fix it - I don't want this to be accidentally merged part way through my changes. |
shanesmithdev
marked this pull request as ready for review
November 20, 2026 10:37
Guilds come to the app on the API dev-null.sh has merged so far: that means we have a guild directory, and if a commit was posted directly into a guild we can show that. Tapping on a guild will open the regular search for the hashtag, in the meantime. Commits posted straight to a guild's board say "posted in [guild] · not shown in general logs", as it does on the web. Guilds with an uploaded icon show a people glyph for now, since devnull serves icons only to a signed-in browser and not over the API. Other features are pending further upstream API changes.
shanesmithdev
force-pushed
the
implement-guilds
branch
from
November 20, 2026 10:39
90342ea to
5c157e2
Compare
Contributor
Author
|
Upstream changes allow for using the uploaded icons for Guilds now, so I'll refactor this to use those rather than my temporary placeholder. |
shanesmithdev
marked this pull request as draft
November 20, 2026 13:19
dev-null.sh now serves guild icons to the app through signed links (dev-null-sh/dev-null.sh#1624), so guilds with an uploaded icon show it in the directory and on "posted in" pills, in place of the people glyph. The links expire after a day or two, and older commits the app keeps can carry an expired one. Once a link has expired, the app shows the guild's emoji instead, unless it has already downloaded that icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: Ready for review. Not blocked.
The first part of bringing /dev/null's guilds to the app, built only on guild API that is already merged and live on dev-null.sh.
Further API changes are in the pipeline and being reviewed today. I'll submit additional PRs that build on top of this one once those extra APIs are available, to bring in the rest of the guild feature set and make have full parity with the web version.
What's in this PR?
Guilds directory:
The message "posted in [guild] · not shown in general logs" under commits posted straight to a guild's board, which is exactly how it also appears on the web.
Handles when guilds are switched off:
A temporary icon for guilds with a custom icon (non-emoji)
Guilds with an uploaded icon show a plain people glyph instead of the custom uploaded icon that you see on the web. I handled it this way because dev-null.sh doesn't serve those icons over any API route yet.
Those guilds still store the default 💻 emoji, but displaying that looked strange because those guild moderators never selected that emoji and it doesn't appear on the web, so showing it would be misleading. dev-null-sh/dev-null.sh#1624 serves icons to API clients through signed URLs. Once it's merged, the real icons replace the glyph.
What's still to come
The rest of guilds needs API work that's open on dev-null.sh, not merged yet. I'll send follow-up PRs as each part lands:
guild_mentionsto API responses.Testing
Pest tests cover:
Locally, the full suite passes. Checked by hand on an iPhone 16e simulator and an Android phone.
Screenshots
guild-post
guilds
guilds-empty
guilds-scrolled
guilds-search
log