Skip to content

[Guilds 01] Browse guilds, and show which guild a commit was posted in - #188

Draft
shanesmithdev wants to merge 2 commits into
NativePHP:mainfrom
shanesmithdev:implement-guilds
Draft

shanesmithdev wants to merge 2 commits into
NativePHP:mainfrom
shanesmithdev:implement-guilds

Conversation

@shanesmithdev

@shanesmithdev shanesmithdev commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Status: Ready for review. Not blocked.

The first part of bringing /dev/null's guilds to the app, built only on guild API that is already merged and live on dev-null.sh.

Further API changes are in the pipeline and being reviewed today. I'll submit additional PRs that build on top of this one once those extra APIs are available, to bring in the rest of the guild feature set and make have full parity with the web version.

What's in this PR?

  • Guilds directory:

    • Opened from a new icon on the Log's bar, before Search
    • Lists guilds biggest first, as the web does, with the same search ("Search names, #handles, and descriptions.")
    • The next page loads as you scroll with infinite scroll, which is even better than the web's Previous and Next buttons
    • Tapping a guild opens the commit search for its hashtag, because we can't implement guild pages yet (coming in a separate PR once the web's API supports it)
  • The message "posted in [guild] · not shown in general logs" under commits posted straight to a guild's board, which is exactly how it also appears on the web.

  • Handles when guilds are switched off:

    • This was the case before general availability, and technically it is still possible that the web app can have guilds switched off again - even if that is unlikely.
    • Because of this, the app handles this gracefully and detects the scenario, hiding the guilds feature when that happens. If it's switched back on again, the app will detect that and show the guilds button again.

A temporary icon for guilds with a custom icon (non-emoji)

Guilds with an uploaded icon show a plain people glyph instead of the custom uploaded icon that you see on the web. I handled it this way because dev-null.sh doesn't serve those icons over any API route yet.

Those guilds still store the default 💻 emoji, but displaying that looked strange because those guild moderators never selected that emoji and it doesn't appear on the web, so showing it would be misleading. dev-null-sh/dev-null.sh#1624 serves icons to API clients through signed URLs. Once it's merged, the real icons replace the glyph.

What's still to come

The rest of guilds needs API work that's open on dev-null.sh, not merged yet. I'll send follow-up PRs as each part lands:

Testing

Pest tests cover:

  • the guild data and the cache;
  • the directory: search, a late answer for an old search term, loading more, empty states, the 404, and the kept first page;
  • the badge, including on Search;
  • hiding and bringing back the Log icon.

Locally, the full suite passes. Checked by hand on an iPhone 16e simulator and an Android phone.

Screenshots

guild-post

notice the "posted in [guild] - not shown in general logs" message in the after screenshots

iOS light iOS dark Android light Android dark
Before
After

guilds

Completely new interface

iOS light iOS dark Android light Android dark
After

guilds-empty

Completely new interface

iOS light iOS dark Android light Android dark
After

guilds-scrolled

Completely new interface. I've scrolled down to show that the emoji icons render, and the rest are using the fallback I've put in place while we wait for the ability to load the custom icons for the other guilds too.

iOS light iOS dark Android light Android dark
After

guilds-search

Completely new interface

iOS light iOS dark Android light Android dark
After

log

Notice the extra Guilds button in the top navigation bar

iOS light iOS dark Android light Android dark
Before
After

@shanesmithdev

Copy link
Copy Markdown
Contributor Author

FYI @simonhamp

@shanesmithdev shanesmithdev changed the title [Guilds] Browse guilds, and show which guild a commit was posted in [Guilds 1/5] Browse guilds, and show which guild a commit was posted in Nov 20, 2026
@shanesmithdev shanesmithdev changed the title [Guilds 1/5] Browse guilds, and show which guild a commit was posted in [Guilds 01] Browse guilds, and show which guild a commit was posted in Nov 20, 2026
@shanesmithdev
shanesmithdev marked this pull request as draft November 20, 2026 10:30
@shanesmithdev

shanesmithdev commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Found a small oversight. Converted to draft temporarily while I fix it - I don't want this to be accidentally merged part way through my changes.

@shanesmithdev
shanesmithdev marked this pull request as ready for review November 20, 2026 10:37
Guilds come to the app on the API dev-null.sh has merged so far: that
means we have a guild directory, and if a commit was posted directly into
a guild we can show that. Tapping on a guild will open the regular search
for the hashtag, in the meantime.

Commits posted straight to a guild's board say "posted in [guild] ·
not shown in general logs", as it does on the web.

Guilds with an uploaded icon show a people glyph for now, since
devnull serves icons only to a signed-in browser and not over the API.

Other features are pending further upstream API changes.
@shanesmithdev

Copy link
Copy Markdown
Contributor Author

Upstream changes allow for using the uploaded icons for Guilds now, so I'll refactor this to use those rather than my temporary placeholder.

@shanesmithdev
shanesmithdev marked this pull request as draft November 20, 2026 13:19
dev-null.sh now serves guild icons to the app through signed links
(dev-null-sh/dev-null.sh#1624), so guilds with an uploaded icon show it
in the directory and on "posted in" pills, in place of the people glyph.

The links expire after a day or two, and older commits the app keeps
can carry an expired one. Once a link has expired, the app shows the
guild's emoji instead, unless it has already downloaded that icon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant