Repository navigation
Look up the archives of a release by the version of its tag - #17
Merged
Merged
Conversation
The attestation and the record on the Packages panel read the latest version that pub.dev lists for a package, which can still be the previous one for minutes after an upload. On 1.0.0 it was for two of the four packages when the record job ran, so that job tried to record the 0.2.0 archives of flutwire_http and flutwire_cloud_functions. Both jobs now look the archive up by the version of the tag and wait for pub.dev to serve it.
|
This pull request adds no capability the code did not already have. 2 files read · 946 ms · against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attestation and the record on the Packages panel in the release workflow looked up each archive through the
latestversion that pub.dev lists for a package. That field can still name the previous version for minutes after an upload. On 1.0.0 it did for two of the four packages when the record job read it, so the job tried to record the 0.2.0 archives offlutwire_httpandflutwire_cloud_functions. Both jobs now look the archive up by the version of the tag, and wait up to ten minutes for pub.dev to serve it. The attestation could have gone wrong the same way. It did not on 1.0.0: the four archives verify, each againstrefs/tags/v1.0.0.Checked locally by extracting the two steps from the workflow file and running them as they are written. The attestation step for the tag
v1.0.0writes the four digests that the published archives have. The record step forv1.0.0finds each archive by its version and the record that was added by hand, and forv0.1.0, which has no records, finds the archive of that version and reaches the write, which was blocked for the test, so nothing was recorded. The workflow only runs on a tag, so GitHub cannot run it before the next release.What this does not change: the record step still gets a 404 from the metadata endpoint with the token of the workflow, which has no write permission there. The records of the next release need to be added by hand, or with a personal access token in the
ARTIFACT_METADATA_TOKENsecret, which the step already prefers.Targets
1.1.0, as an Internal entry in the changelog.