Hot-fix CCCL based TMA by simply disabling it for the moment - #2777
Open
seberg wants to merge 1 commit into
Open
Hot-fix CCCL based TMA by simply disabling it for the moment#2777seberg wants to merge 1 commit into
seberg wants to merge 1 commit into
Conversation
As linked in the referenced issue, my current understanding is that CCCL will stop requiring loading nvrtc which totally changes how we should be fixing things. So the full fix which should rely on using CCCL as a submodule needs to wait for that. Until then, let's maybe just disable it as a very minimal fix that bakes in status-quo but doesn't go up in flames on systems where CCCL headers happen to be found...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As linked in the referenced issue, my current understanding is that CCCL will stop requiring loading nvrtc which totally changes how we should be fixing things.
So the full fix which should rely on using CCCL as a submodule needs to wait for that.
Until then, let's maybe just disable it as a very minimal fix that bakes in status-quo but doesn't go up in flames on systems where CCCL headers happen to be found...
See also: NVIDIA/cccl#11231
(We can work around this part, which is already the state of gh-2428, but if CCCL fixes it on main soonish and we vendor CCCL, then it feels like we might as well wait a bit.)
Checklist