Skip to content

fix(cli): allow multiple provider profiles to be deleted - #3032

Open
grs wants to merge 1 commit into
NVIDIA:mainfrom
grs:multi-profile-delete
Open

fix(cli): allow multiple provider profiles to be deleted#3032
grs wants to merge 1 commit into
NVIDIA:mainfrom
grs:multi-profile-delete

Conversation

@grs

@grs grs commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Makes provider profile deletion more consistent with that of sandboxes and profiles by allowing the deletion of multiple items.

Related Issue

Closes #3029

Changes

  • Allow multiple profiles to be specified in the provider profile delete command.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Gordon Sim <gsim@redhat.com>
@grs
grs requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners August 31, 2026 12:18
@copy-pr-bot

copy-pr-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@elezar elezar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The batch loop still exits on the first RPC error because .into_diagnostic()? is inside the loop. For provider profiles, a missing, source-managed, or in-use profile returns an RPC error, so later IDs are never attempted.

This matches the current provider delete fail-fast behavior, but it conflicts with this issue's acceptance criteria to attempt each supplied profile and report each result independently. Could we continue through all IDs, print each failure, and return an aggregated nonzero error afterward? Please also add a mixed-result test such as success, in-use or missing, then success.

Follow-up: sandbox delete, provider delete, and workspace delete also stop on the first RPC error. Please consider a separate issue to define and standardize batch-delete error semantics across the CLI, including per-target reporting and aggregate exit status.

@grs

grs commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@elezar I propose to reword the acceptance criteria for the associated issue, then open a separate issue and PR for improving the error handling of deletion across all three resource types. Is that good with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): allow multiple provider profiles to be deleted

2 participants