feat(providers): make profiles authoritative - #2962
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-2962.docs.buildwithfern.com/openshell |
PR Review StatusThe current head is a patch-identical rebase of the already-reviewed change, so no new code review was needed and all prior Gator findings remain resolved. The required E2E run did start, but two provider/OIDC failure classes introduced by the authoritative-profile behavior need author follow-up before pipeline monitoring can continue. Action required: @johntmyers, please align the Python OIDC provider fixtures with the credentials declared by their selected profiles, and fix or update the Rust PKCE authorization path so a correct non-member denial is not reported as an unsupported provider type/profile. Push a new head with the focused E2E coverage passing. Blocking findings:
Carried findings:
Gator metadata
|
59aacf2 to
a096026
Compare
PR Review StatusThanks @johntmyers. I checked the Blocking findings:
Carried findings:
Gator metadata
|
Closes #1988 Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
a096026 to
60598bc
Compare
PR Review StatusThe current head is a patch-identical rebase of the already-reviewed change, so no additional code review is needed and no blocking Gator findings remain. The required current-head E2E workflow is queued and running, so pipeline monitoring can resume. Blocking findings:
Carried findings:
Gator metadata
|
Summary
Make provider profiles authoritative for new provider creation and discovery, removing the Providers v2 compatibility switch and legacy public provider workflows.
Related Issue
Closes #1988
Changes
providers_v2_enabledand always composes attached profile policy for sandbox-scoped policiesopenaiandanthropicprofiles and retires publicgeneric,gitlab,opencode, andoutlookselection/discoveryTesting
mise run cimise run testmise run e2e:rustmise run e2e:python(89 passed, 84 skipped)mise run docs:build:strictcargo test --manifest-path e2e/rust/Cargo.toml --all-features --no-runcargo test --manifest-path examples/governance-interceptor/Cargo.tomlChecklist