Conversation
Signed-off-by: Hongyuan Du <du-hongyuan@outlook.com>
Signed-off-by: Hongyuan Du <du-hongyuan@outlook.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe cache-aware encoder and runner now use a shorter first mel chunk and distinct steady-state chunk geometry. The encoder preserves first-chunk output, while the runner manages overlap, flushing, resets, and validation. ChangesCache-aware stream geometry
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant CacheStreamRunner
participant EncoderConfig
participant FastConformer
CacheStreamRunner->>EncoderConfig: calculate first-chunk mel length
CacheStreamRunner->>FastConformer: process selected mel chunk
FastConformer->>FastConformer: retain first output or drop later overlap
CacheStreamRunner->>CacheStreamRunner: flush and reset chunk state
Merge Risk: ⚪ Minimal · up to The cache-stream geometry change includes coverage for first chunks, steady-state overlap, EOF, reset, and forced-EOU behavior. No concrete merge-blocking issue was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 10.53% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 6 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What changed
The first audio block has no previous block to overlap. The current code still adds front padding and applies the crop used for later blocks.
This patch gives the first block its own layout: for Nemotron at R13, 105 real feature frames, with no added prefix or overlap crop. It also handles R0, short input, end-of-stream and reset. The existing 9-frame history and all later-block processing stay unchanged. Model weights, decoding rules and endpointing policy are unchanged.
Tests
Tested on an M2 Pro, macOS 26.6.2, with ASR/diarization/tests enabled, Metal enabled and TTS/microphone capture disabled.
Limits: CUDA/Vulkan were not tested. Another local audio sample showed Metal concurrency failures on both main and an earlier revision of this fix; their cause is not established or addressed here. The full pre-commit command could not download ShellCheck. All other hooks passed individually, and the exact pinned ShellCheck 0.10.0 passed separately on all eight shell scripts.
Provenance
Both commits are DCO-signed. Existing license notices are preserved; the contribution is Apache-2.0. AI assistance (Codex) was used. No application code, audio, transcripts, models or logs are included; the new test generates its own input.
Local validation inputs only:
1c8deae: NVIDIA, OpenMDW 1.1.a84770f: BAAI, CC-BY-NC-SA-4.0; 48 utterances joined chronologically.Summary by CodeRabbit
Bug Fixes
Tests