Skip to content

Decompile dCenterSaveMng_c - #135

Closed
alvaroms97 wants to merge 2 commits into
NSMBW-Community:masterfrom
alvaroms97:decomp/center-save-mng-c
Closed

alvaroms97 wants to merge 2 commits into
NSMBW-Community:masterfrom
alvaroms97:decomp/center-save-mng-c

Conversation

@alvaroms97

Copy link
Copy Markdown
Contributor

Decompiles dCenterSaveMng_c (singleton manager for saved "center" positions keyed by position + parameter) in full: constructor, destructor, allDoDelete, center_check, and center_entry, on top of the existing cLineMg_c/cLineNd_c doubly-linked list.

alvaroms97 added a commit to alvaroms97/NSMBW-Decomp that referenced this pull request Sep 10, 2026
@decomp-dev

decomp-dev Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Report for SMNP01 (aef4d15 - 6f4f7b6)

Total code: 6263172 bytes (-12 bytes)
Total functions: 39967 (-1)
📈 Matched code: 8.89% (+0.01%, +568 bytes)
📈 Linked code: 8.91% (+0.01%, +568 bytes)
📈 Matched data: 2.25% (+0.00%, +4 bytes)
📈 Linked data: 3.99% (+0.00%, +20 bytes)

✅ 13 new matches
Unit Item Bytes Before After
dol/bases/d_center_save_mng.cpp dCenterSaveMng_c::center_entry(const mVec3_c*, unsigned char, short) +256 0.00% 100.00%
dol/bases/d_center_save_mng.cpp dCenterSaveMng_c::allDoDelete() +96 0.00% 100.00%
dol/bases/d_center_save_mng.cpp dCenterSaveMng_c::center_check(const mVec3_c*, unsigned char, short*) +96 0.00% 100.00%
dol/bases/d_center_save_mng.cpp dCenterSaveMng_c::~dCenterSaveMng_c() +92 0.00% 100.00%
dol/bases/d_center_save_mng.cpp __sinit_\d_center_save_mng_cpp +20 0.00% 100.00%
dol/bases/d_center_save_mng.cpp dCenterSaveMng_c::dCenterSaveMng_c() +8 0.00% 100.00%
dol/bases/d_center_save_mng.cpp .ctors +4 0.00% 100.00%
runtime/global_destructor_chain.c __register_global_object -4 100.00% 100.00%
runtime/global_destructor_chain.c __register_global_object -4 100.00% 100.00%
runtime/global_destructor_chain.c __register_global_object -4 100.00% 100.00%
runtime/global_destructor_chain.c __destroy_global_chain -12 100.00% 100.00%
runtime/global_destructor_chain.c __destroy_global_chain -12 100.00% 100.00%
runtime/global_destructor_chain.c __destroy_global_chain -12 100.00% 100.00%
🥀 3 broken matches
Unit Item Bytes Before After
runtime/global_destructor_chain.c .dtors -8 100.00% 0.00%
runtime/global_destructor_chain.c .dtors -4 100.00% 0.00%
runtime/global_destructor_chain.c .dtors -4 100.00% 0.00%
📈 4 improvements in unmatched items
Unit Item Bytes Before After
dol/bases/d_center_save_mng.cpp .sbss +12 0.00% 80.00%
runtime/global_destructor_chain.c .sbss +5 0.00% 66.67%
runtime/global_destructor_chain.c .sbss +5 0.00% 66.67%
runtime/global_destructor_chain.c .sbss +5 0.00% 66.67%
📉 3 regressions in unmatched items
Unit Item Bytes Before After
runtime/global_destructor_chain.c .bss -5 66.67% 0.00%
runtime/global_destructor_chain.c .bss -5 66.67% 0.00%
runtime/global_destructor_chain.c .bss -5 66.67% 0.00%

Also replace the arrow character in the class brief with ASCII.
@CLF78

CLF78 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #140 .

@CLF78 CLF78 closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants