Skip to content

fix: use all Heatmap samples when selection blank - #102

Merged
phoman14 merged 6 commits into
DEVfrom
DEV-heatmap-sample-filter-messaging
Oct 14, 2026
Merged

phoman14 merged 6 commits into
DEVfrom
DEV-heatmap-sample-filter-messaging

Conversation

@phoman14

@phoman14 phoman14 commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Changes

  • Treat a blank sample.names selection in heatmapSC() as all values in the selected sample metadata column.
  • Document the blank-selection behavior in roxygen comments.
  • Add a focused regression test.
  • Add a NEWS entry for the user-facing behavior change.

Issues

None.

PR Checklist

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update the docs if there are any API changes (roxygen2 comments, vignettes, readme, etc.).
  • Update NEWS.md with a short description of any user-facing changes and reference the PR number.
  • Run devtools::check() locally and fix all notes, warnings, and errors. Not run per requested focused-test scope; devtools::load_all() followed by tests/testthat/test-Heatmap.R passed locally (47 passes, 7 expected CRAN skips).

@phoman14
phoman14 merged commit c88aca3 into DEV Oct 14, 2026
6 of 11 checks passed
@phoman14
phoman14 deleted the DEV-heatmap-sample-filter-messaging branch October 14, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant