test(placement): ignore foreign-project instances in packing harness - #437
Merged
Merged
Conversation
Incus get_instances(project, location) returns that project only. Stamping the query project onto every snapshot instance let other projects fill gha-fleet RAM. Signed-off-by: rldyourmnd <danil@nddev.it.com> Co-authored-by: Cursor <cursoragent@cursor.com>
rldyourmnd
deleted the
test/placement-starlark-project-filter-20260908
branch
September 8, 2026 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_instances/get_instances_countnow return only the queried Incus project.InstanceSnapshot.Projectstill means the queried project, so existing 4GiB packing fixtures are unchanged.not-fleetno longer fills gha-fleet RAM.Test plan
go test -C internal/incusplacement/starlarkexec ./...go vet -C internal/incusplacement/starlarkexec ./...go test ./internal/incusplacementgo.mod/go.sumunchanged vs provider pin