test(placement): execute Starlark packing against a mock Incus cluster - #435
Merged
Merged
Conversation
…cluster String asserts cannot prove packing. Run the rendered script with Incus call shapes so an 8GiB worker still fails on four hosts each holding two 4GiB jobs and lands on the empty member of a packed occupancy. Signed-off-by: rldyourmnd <danil@nddev.it.com>
Execute the rendered scriptlet in a nested module so packing tests keep the real Incus interpreter without invalidating the pinned provider derivative. Signed-off-by: rldyourmnd <danil@nddev.it.com> Co-authored-by: Cursor <cursoragent@cursor.com>
get_instances_count(..., true) is running instances plus InstanceCreate operations, not extras-only. A create with no record must still pack. Signed-off-by: rldyourmnd <danil@nddev.it.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strings.Contains.[12,12,8,0]GiB lands it on the empty member.Test plan
GOTOOLCHAIN=go1.26.7 go test ./internal/incusplacement