Skip to content

https://github.com/Mu2e/Offline/pull/1960 sub PR #5 - #1966

Open
YongyiBWu wants to merge 4 commits into
Mu2e:mainfrom
YongyiBWu:vdresampler-configure
Open

https://github.com/Mu2e/Offline/pull/1960 sub PR #5#1966
YongyiBWu wants to merge 4 commits into
Mu2e:mainfrom
YongyiBWu:vdresampler-configure

Conversation

@YongyiBWu

Copy link
Copy Markdown
Contributor

VDResampler: job configuration and fcl emission

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @YongyiBWu,
You have proposed changes to files in these packages:

  • MachineLearningTools
  • STMMC

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 2fa10e5: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☔ The build is failing at 2fa10e5.

scons: *** [build/al9-prof-e29-p106/Offline/tmp/STMMC/src/VDResamplerGenerateFromModel_module.os] Error 1
scons: *** [build/al9-prof-e29-p106/Offline/tmp/STMMC/src/VDResamplerGenerateMix_module.os] Error 1
Test Result Details
test with Command did not list any other PRs to include
merge Merged 2fa10e5 at f6e4350
build (prof) Log file.
ceSimReco 〰️ Log file.
g4test_03MT 〰️ Log file.
transportOnly 〰️ Log file.
POT 〰️ Log file.
g4study 〰️ Log file.
cosmicSimReco 〰️ Log file.
cosmicOffSpill 〰️ Log file.
ceSteps 〰️ Log file.
ceDigi 〰️ Log file.
muDauSteps 〰️ Log file.
ceMix 〰️ Log file.
rootOverlaps 〰️ Log file.
g4surfaceCheck 〰️ Log file.
trigger Log file.
check_cmake 〰️ Log file.
FIXME, TODO ➡️ TODO (1) FIXME (0) in 11 files
clang-tidy ➡️ 8 errors 108 warnings
whitespace check ➡️ found whitespace errors

N.B. These results were obtained from a build of this Pull Request at 2fa10e5 after being merged into the base branch at f6e4350.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

The new constructor parameters are appended after initializeRandomWeights
rather than placed logically, and SBDMGeneratedSample carries a temporary
conversion to vector<double>, so the VDResampler modules already in the
tree keep compiling against this header. Both are undone by the later PRs
that replace those callers.
Also restores the logical constructor parameter order: this PR replaces
the only caller that constructed a model directly, and the generators
construct through loadModel, so nothing depends on the temporary order
any more. SBDMGeneratedSample keeps its conversion for the generators.
@YongyiBWu
YongyiBWu force-pushed the vdresampler-configure branch from cdc641d to 06546d8 Compare September 5, 2026 11:51
@YongyiBWu

Copy link
Copy Markdown
Contributor Author

@FNALbuild run build test

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 06546d8: build (Build queue - API unavailable)

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 06546d8.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 06546d8 at f6e4350
build (prof) Log file. Build time: 04 min 27 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file. Return Code 1.
check_cmake Log file.
FIXME, TODO ➡️ TODO (1) FIXME (0) in 11 files
clang-tidy ➡️ 8 errors 108 warnings
whitespace check ➡️ found whitespace errors

N.B. These results were obtained from a build of this Pull Request at 06546d8 after being merged into the base branch at f6e4350.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants