https://github.com/Mu2e/Offline/pull/1960 sub PR #5 - #1966
Conversation
|
Hi @YongyiBWu,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for 2fa10e5: build (Build queue - API unavailable) |
|
☔ The build is failing at 2fa10e5.
N.B. These results were obtained from a build of this Pull Request at 2fa10e5 after being merged into the base branch at f6e4350. For more information, please check the job page here. |
The new constructor parameters are appended after initializeRandomWeights rather than placed logically, and SBDMGeneratedSample carries a temporary conversion to vector<double>, so the VDResampler modules already in the tree keep compiling against this header. Both are undone by the later PRs that replace those callers.
Also restores the logical constructor parameter order: this PR replaces the only caller that constructed a model directly, and the generators construct through loadModel, so nothing depends on the temporary order any more. SBDMGeneratedSample keeps its conversion for the generators.
cdc641d to
06546d8
Compare
|
@FNALbuild run build test |
|
⌛ The following tests have been triggered for 06546d8: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 06546d8.
N.B. These results were obtained from a build of this Pull Request at 06546d8 after being merged into the base branch at f6e4350. For more information, please check the job page here. |
VDResampler: job configuration and fcl emission