Remove Track PID in Run 1B ntupling - #405
Open
michaelmackenzie wants to merge 1 commit into
Open
Conversation
… never made trkPIDTags was set to ["TrkPID:MergeKKLines"], but neither TrkDtDt nor TrkPID is ever run over "MergeKKLines" in this fcl's producer path (PathExt only runs MergeKKLine; TrkPIDPath is never included, and the TrkPID/TrkDtDt producer configs' KalSeeds/kalSeeds lists don't mention MergeKKLines either). fillTrkPID : false (already set just below, "Not yet implemented") does not gate this -- EventNtupleMaker_module.cc declares a fillTrkPID() accessor but never actually calls it, so branch creation is driven purely by trkPIDTags being non-empty (unlike fillTrkDtDt, which *is* checked, hence no "trkdtdt" branch appears despite trkDtDtTag also pointing at a product that isn't produced). Net effect: EventNtupleMaker created a "trkpid" branch that is always empty regardless of how many tracks an event has, and any rooutil-based reader that indexes it per-track (rooutil::Event::Update()'s UpdateObject(), called for every track via std::vector::at()) throws std::out_of_range on the first event with a track. Confirmed on a locally produced Run1B ntuple, independent of anything else in this session's Mu2eEvtAna work. Fix: set trkPIDTags : [] to match the already-expressed intent, so no "trkpid" branch is created at all. Verified equivalent: EvtAna.root output from Mu2eEvtAna against the regenerated ntuple is bit-identical (622 histograms, 4 trees) to the prior workaround (a wrapper fcl that also set trkPIDTags : []); ConvAna and Run1BAna also now run against the ntuple with no workaround needed, with unchanged cut-flow results. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sophiemiddleton
approved these changes
Sep 10, 2026
ehrlich-uva
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No PID is produced for the Run 1B processing, so the tag should be removed. If not, the ntuple produces an empty branch that then can cause faults in RooUtil due to assumed index matching between branches.