Repository navigation
fix: group untagged sections under one target and show file counts in the HTML report - #258
Open
alielsokary wants to merge 2 commits into
Open
alielsokary wants to merge 2 commits into
alielsokary wants to merge 2 commits into
Conversation
alielsokary
requested review from
aleksandergrzyb,
ecamacho and
polac24
as code owners
September 21, 2026 15:45
In flattened xcodebuild logs, sections without an (in target ...) tag were appended to the root and reported as targets. Xcode 26 and later emit tens of thousands of such sections (explicit module scans), so the HTML report grew to 1.4GB and the target list and Slowest targets chart were wrong. Group them under a single Build system target. Signed-off-by: Ali Elsokary <ali.elsokary.w@gmail.com>
The index page only loads the main step and the targets, so counting detail steps there always gave 0. Write the counts from the reporter instead. Signed-off-by: Ali Elsokary <ali.elsokary.w@gmail.com>
alielsokary
force-pushed
the
fix/untagged-sections-as-targets
branch
from
September 21, 2026 15:46
4f21fb3 to
7a1c622
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for the HTML report on xcodebuild logs.
Untagged sections were reported as targets (#220, #202)
In a flattened log, sections without an
(in target ... from project ...)tag were appended to the root and typed as targets. Xcode 26 and later emit one such section per explicit module scan, so a single build produced tens of thousands of fake targets, one HTML page each. They are now grouped under a singleBuild systemtarget.C files and Swift files always showed 0 on the index page (#161)
targets.jsonly carries the main step and the targets, so counting detail steps on the index page always gave 0. The reporter now writes the counts intotop_files.js.Measured on a ResidentApp Debug build log, Xcode 27.0:
Swift files still shows 0 on Xcode 14+ logs because
SwiftCompilesteps are not typed asswiftCompilationyet. #256 fixes that and the count follows from it.