Repository navigation
GEOPY-3082: Crash converting OMF block model - #137
Merged
Merged
Conversation
github-actions
Bot
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #137 +/- ##
========================================
Coverage 92.79% 92.80%
========================================
Files 27 27
Lines 1526 1528 +2
========================================
+ Hits 1416 1418 +2
Misses 110 110
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Mapped no-data indices are corrupted, and array comparison failures are silently suppressed.
1 open finding
What changed in this PR
Addresses the OMF block-model conversion crash by adapting the geoh5 integration to updated dependency APIs.
Changes:
- Updates geoh5py imports and geometry-origin handling.
- Adjusts conversion fixtures and comparison behaviour.
- Refreshes locked dependencies.
| File | Description |
|---|---|
| tests/convert_volume_test.py | Updates mapped indices and origin assertions. |
| tests/conftest.py | Expands the point fixture to 5,000 values. |
| poetry.lock | Updates geoh5py and other dependencies. |
| omf/fileio/utils.py | Adds exception handling around array comparisons. |
| omf/fileio/geoh5.py | Adapts imports and origin access to updated APIs. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
benk-mira
requested changes
Oct 8, 2026
Removed try-except block around assert_allclose for array comparison. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sebhmg
approved these changes
Oct 13, 2026
benk-mira
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3082 - Crash converting OMF block model