Repository navigation
GEOPY-3100: Crash on active cells of DC2D inversion - #995
Merged
Merged
Conversation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unmasked EM survey copies raise TypeError because the new condition negates a None mask.
1 open finding
What changed in this PR
Prevents unnecessary reference-ID renumbering when copying complete surveys.
Changes:
- Renumbers reference IDs only when the complement mask excludes entries.
| File | Description |
|---|---|
geoh5py/objects/surveys/base.py |
Conditionally renumbers copied survey references. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #995 +/- ##
========================================
Coverage 91.02% 91.02%
========================================
Files 130 130
Lines 11324 11325 +1
Branches 2090 2091 +1
========================================
+ Hits 10308 10309 +1
Misses 531 531
Partials 485 485
🚀 New features to boost your workflow:
|
benk-mira
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3100 - Crash on active cells of DC2D inversion