Skip to content

feat: add reconnect grace period config and proxy wiring for multiplayer sessions - #492

Open
Muhd010 wants to merge 1 commit into
MindFlowInteractive:mainfrom
Muhd010:fix/issue-480-reconnect-grace-period
Open

Muhd010 wants to merge 1 commit into
MindFlowInteractive:mainfrom
Muhd010:fix/issue-480-reconnect-grace-period

Conversation

@Muhd010

@Muhd010 Muhd010 commented Oct 23, 2026

Copy link
Copy Markdown

Overview

This PR wires a configurable reconnect grace period into the API gateway so that a dropped multiplayer player's seat can be held for a short window before release. The changes are limited to gateway configuration and proxy module setup; session-side seat reservation, rejoin handling, expiry, and notifications are not implemented in these files.

Related Issue

Changes

🔌 Gateway Configuration

  • [MODIFY] microservices/api-gateway/src/config/configuration.ts

    • Adds a reconnect grace period setting, read from the environment with a default value, so the hold window can be tuned per deployment.
  • [MODIFY] microservices/api-gateway/src/proxy/proxy.module.ts

    • Exposes the grace period configuration to the proxy layer so multiplayer routes forwarded through the gateway can use it.

Verification Results

Not run as part of this change. No test files were modified in this PR.

Acceptance Criteria Status
Players rejoin within the window with progress intact ⏳ Pending: requires session-side seat hold and rejoin logic
Seats released after expiry ⏳ Pending: requires session-side expiry handling
Other players are notified ⏳ Pending: requires session-side drop/rejoin notifications

Closes #480

@Muhd010
Muhd010 force-pushed the fix/issue-480-reconnect-grace-period branch from 28b7506 to 6fc1e17 Compare November 10, 2026 18:49
@drips-wave

drips-wave Bot commented Nov 10, 2026

Copy link
Copy Markdown

Warning

Possible malicious code: please review before merging.

An automated security scan flagged files in this pull request that appear to contain malicious code. Code like this can run automatically when a project is opened in an editor or its dependencies are installed, so it could compromise the machine of anyone who checks out this branch.

Automated scans can be wrong, so this may be a false positive. Maintainers: please review the flagged files carefully before merging, on GitHub in your browser rather than by checking out the branch. The malicious part is often hidden far off to the right of an ordinary-looking line, so scroll sideways through each file.

@Muhd010: this pull request adds or changes these files, possibly without your knowledge. Malware like this spreads by adding itself to repositories on machines it has infected, so your machine might be compromised. Please undo these changes in this pull request, and don't open or run other projects on that machine until you've checked it.

Flagged files at commit 6fc1e17:

Only merge once you're confident these files are safe.

ℹ️ Posted automatically by Drips Wave. Questions? Contact support@drips.network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconnect Grace Period

1 participant