Repository navigation
Open the share sheet on iPad for offline sessions and debug logs - #35
Merged
Merged
Conversation
share_plus refuses to open the sheet on iPad without a sharePositionOrigin, so Download JSON on an offline session and Share on a debug log did nothing there. Both buttons now pass their own on-screen rect as the popover anchor, and a failed offline download is logged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An iPad user (iPad Pro 11" 3rd gen, iOS 26.4.2, app 1.4.0) reported they can't download offline sessions. Their log shows the session saved (
2026-10-16-3.json, 32 pings) but no[OFFLINE] Shared sessionline afterwards.share_plus 12.0.1 returns
sharePositionOrigin: argument must be seton iPad when no popover anchor is given, so the sheet never opens. Two buttons call it without one:shareDebugLogcatches the error itself, so it failed silently.Change
lib/utils/share_origin.dart:globalRectOf(BuildContext)returns the widget's global rect, or null before layout.shareOfflineSessionandshareDebugLogtake an optionalsharePositionOriginand pass it toShareParams.Builderand pass their own rect.[OFFLINE] Failed to download session …to the debug log.iPhone and Android ignore the origin. The web download path (
kIsWeb) is unchanged.Checks
flutter analyze: no issuesflutter test: all 2442 passed