Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Ready for review at All nine GitHub checks passed. The six-browser matrix finished with 715 passed and 29 browser-specific skips. Validation and Lighthouse are green; local checks also covered both production and subpath preview builds, 33 IATA polygons, all 13 province outlines, archived data, old links, firmware variants, and saved-draft recovery. The map and configurator now share MeshMapper's IATA data. Please pay particular attention to the Canada-wide catalogue change, the ON/QC-only shared scope, and the local-versus-bridge flood policy. This does not claim that every local network has migrated. Before merge: the production owner still needs to deploy and verify the gateway retirement described in |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8799f3eee0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
PR #108 is now deployed to the Canadaverse test site at Verified against the public host:
This is a preview-only deployment. Meshcore.ca production and its submission gateway were not changed; the production-owner gateway verification remains a pre-merge requirement. Preview deployment and verification are now a required handoff step for future meshcore.ca work. |
|
|
Added and deployed the six complementary IATA starter regions at
Try them on the preview map or read the starter-region guide. The 33 MeshMapper geometries remain unchanged. The six additions are separately labelled MeshCore Canada starter regions, use the same flat scope syntax, and do not generate Verification for this exact commit:
Production meshcore.ca and its submission gateway were not changed. The gateway owner's pre-merge verification remains required. |
|
All seven follow-up improvements are now included in
Preview artifact: Review entry points: region map, migration checker in step 4, French map, and ON/QC guide. The pre-existing production-gateway retirement step remains a production-owner action before merge, as documented in the PR. The new weekly review workflow activates after merge and never publishes boundaries automatically. |
|
The incorrect gap boundaries are fixed in The reported point now resolves to YKF, Goderich to YXU, and Kincardine to YLK. Sudbury remains YSB around Sudbury. Gap assignments now consider all eligible regional centres, including existing MeshMapper regions, instead of making newly added hubs absorb the rest of a province. Published MeshMapper polygons are unchanged. Added areas remain separate, labelled planning extensions using the nearby IATA code. The map, configurator, profiles and directory distinguish published boundaries from planning areas in English and French. Saved coordinate links carrying the old incorrect YSB assignment cannot generate commands until corrected. The Canada overview and map height are also fixed. Verification for this exact candidate:
Preview artifact SHA-256: If you copied a configuration for an affected gap location from the previous preview, regenerate and review it. The existing production-gateway retirement step remains an owner action before merge, as documented in the PR. |
Preserve MrAlders0n's clarification and align English/French configurator and reference wording. Keep legacy URLs and forwarding commands compatible; cover boundary and shared-IATA cases.
|
Folded #112 into this PR at The guide, configurator and reference now use city repeater / edge repeater consistently in English and French. A location on the outer boundary alone stays city mode; edge mode is for regular links between different IATA regions. Ottawa and Gatineau still count as one region ( The preview is deployed and verified at this exact commit. Try the configurator or the updated guide.
The previous preview is retained for rollback. Production, brokers and radios are unchanged. The production-owner gateway step documented above is still required before merging #108. |
|
Hey, heads up, we just shipped a proper zones API so you don't have to scrape the homepage anymore: https://wiki.meshmapper.net/zones-api/
A few things this fixes vs the current fetch script:
It's cached for an hour and has an ETag, so your weekly check is basically free. Let me know if you need anything else in it. |
Preserve the shared IATA generator while including neighbour lookup, cleanup choices and expandable explanations in both languages.
Cache public API responses with ETags, review null boundaries and 2-6 character region codes, and preserve the approved map snapshot. Fix polygon labels and prevent background clicks from overwriting selected region names.
|
Updated at @MrAlders0n — the importer now uses the official Zones API, not the homepage or private map endpoints. It follows the returned region URLs, supports 2–6-character codes and null boundaries, and records group metadata. The weekly review caches responses for an hour, uses ETags after expiry, and spaces requests below the shared limit. HTTP errors stop the run without replacing its candidate. All 33 live API boundaries validated. A second import passed with network requests blocked, confirming cache reuse. The approved map snapshot remains unchanged: the API's shape differences are within its documented rounding precision, and future boundary changes still require review rather than automatic publication. Also included:
All nine GitHub checks passed. CI recorded 930 browser passes, one Firefox navigation test that passed on retry, and 29 platform-specific skips. That Firefox journey then passed three live-preview runs with retries disabled. All 100 hosted desktop/mobile regressions passed, along with verification of 131 public pages and 17 asset hashes. The previous preview is retained for rollback. Production, brokers and radios are unchanged. #108 remains unmerged pending community discussion and approval, plus the existing production-owner gateway verification. No Discord or forum messages were posted. |
Gate personal companion scope changes on the announced Phase 2, preserve standard-settings opt-in, distinguish scope-only output, and clarify Phase 3 and planning assignments in English and French.
|
Aligned the rollout guidance at
All nine GitHub checks passed: 967 browser passes, 29 platform-specific skips, no flaky tests. Local checks included 203 unit/helper tests and 72 targeted browser checks. All 12 focused live-preview checks passed with retries disabled, plus public verification of 131 pages and 17 assets. An initial run hit Cloudflare 502 pages; the origin stayed healthy, affected routes recovered, and the unchanged checks then passed. No server settings or test thresholds were changed. Previous preview retained for rollback. Production, brokers and radios are unchanged. Community review and the existing production-owner gateway verification remain required before merging. |
|
The configurator and region map now share the ON/QC proposal's colours, rounded cards, buttons and command-copy controls in both languages and themes. The scope labels use the same blue, green, purple and dashed-neutral styling. This reuses the existing shared design tokens; no new dependency. Preview is updated to All nine GitHub checks passed. The browser run recorded 989 passes, two mobile Safari timeouts that passed on retry, and 29 platform skips. Both timed-out journeys also passed three hosted repetitions each with retries disabled. The 28 focused hosted language/theme/contrast/rollout checks passed without retries, and public verification matched all 131 pages and 18 key assets with no application errors or CSP violations. Boundaries, generated commands, rollout guidance and opt-in settings are unchanged. Production is untouched; the previous preview ( |
|
#114 is incorporated into #108 and deployed to preview at
All nine CI checks passed: 999 browser passes, four mobile WebKit styling cases that passed on retry after 30-second timeouts, and 29 platform skips. All 32 focused hosted English/French checks passed with retries disabled, including those four styling cases. Public verification matched all 131 pages and 18 assets, with no application errors or CSP violations. The 203 unit/helper tests and 2,584 independent geographic checks also passed. The previous preview ( |
|
Quinte feedback addressed in The proposal now uses the shared catalogue for all 24 ON/QC IATA codes, not four hardcoded area choices. Quinte ( The English and French pages now have a city/IATA finder near the top, a scope summary, direct command links and shareable settings. Search failures clear old commands, ambiguous places require a choice, and proposed areas remain labelled. Live Quinte, Belleville and Trenton searches resolve to
Verification: all nine GitHub checks passed, 203 local unit/helper tests passed, all 60 new finder cases passed across six browser configurations, and all 60 focused hosted checks passed with retries disabled. CI had one existing French migration timeout on mobile WebKit that passed on retry; it also passed on preview without retries. Public checks verified 131 pages and 18 asset hashes with no application errors or CSP violations. No boundary, rollout-phase or production changes. The configurator's standard settings remain opt-in, |
|
Implemented the region/proposal UX update and the requested preparation/activation split.
English proposal · Proposition en français · Configurator Verified candidate: The browser matrix now tests each firmware setup independently, and WebKit jobs use a dedicated worker to avoid contention. Timeouts, retry policy, assertions and performance thresholds are unchanged. The previous preview ( Please review the revised cutover timing in particular. #108 is still open; a preview deployment is not a rollout announcement. The existing production-owner gateway verification remains a pre-merge requirement. |
|
@MrAlders0n @446564 — please review the updated candidate
YKF/YYZ/onny preview — English · French All nine CI checks passed. There was one mobile WebKit retry; that exact French Goderich journey then passed three hosted runs with retries disabled. The 44 focused hosted tests, 214 JavaScript tests, geography checks, 131-page public audit and 19 asset-hash comparisons passed. Before merge, the maintainer still needs to deploy and verify the existing submission-gateway retirement update. That deployment was explicitly left to the maintainer. Production website, gateway, brokers and radios are unchanged. Previous preview @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 727d2696ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Updated in The latest requested country scope is 218 JavaScript tests, 16 Python content tests, 2,584 geometry checks, 40 hosted browser tests, all 131 public pages and 19 asset-hash checks passed. The local browser run had one mobile-WebKit timeout; that interaction passed three isolated no-retry repetitions and the hosted run. No test timeouts or assertions were relaxed. Full CI is still finishing its WebKit projects. @MrAlders0n @446564 please review the updated scope naming and rollout wording. The production gateway deployment remains a maintainer-owned pre-merge requirement; it was not changed. Previous preview @codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Final verification for The preview serves this exact commit and uses The remaining merge gates are human maintainer approval and the maintainer-owned production submission-gateway deployment/verification. Production website, gateway, brokers and radios were not changed. Previous preview |
|
Conflicts with current The preview serves this exact candidate. Browser qualification: the hosted focused suite had 113 passes and 3 mobile-WebKit readiness/time-limit failures. All three passed three isolated no-retry repetitions afterward (9/9). The earlier local two-worker run had 96 passes/20 timing or readiness failures. No timeout or assertion was weakened; these results are recorded in the PR description. Still not merge-ready: CI run 40958112905 stops on 18 expired verified-page reviews. I left the review dates and validator unchanged. Those English/French guide pairs need documented re-review before CI can complete. Human approval and the maintainer-owned gateway deployment also remain outstanding. Production website, gateway, radios and brokers are unchanged. Previous preview |
Summary
Unifies Canada's map and configurator with MeshMapper IATA regions, including #112, #114 and review feedback. Scopes are independent labels; preparation remains separate from locally coordinated activation. This remains a proposal, not a rollout announcement.
Current candidate:
7daceca0687d4df312fed9a07930c6da2d683b9cCurrent main incorporated:
85c7a463af4b397e0e7660bc1b07f8efe7938bb5Preview: https://canadaverse.org/meshcore-canada/
Conflicts resolved; not yet merge-ready because CI is blocked by expired guide reviews.
October 29 conflict resolution
Merged current
maininto the PR without rewriting its history. Preserved both upstream additions: the bilingual Station G3 guide and the shared table styling.The conflict was in
mkdocs.ymlstylesheet references. The resolution keeps the IATA/proposal palette tokens and components, uses the combined base stylesheet, and gives that stylesheet a new cache version (20261029-1). No dependencies were added.The IATA catalogue and boundary coordinates are unchanged. Canada remains
can;nais reserved,onnyis opt-in, and preparation preserves existing scopes and wildcard/default settings. The map, configurator, proposal and English/French guidance retain their shared scope logic.Current verification
Preview artifact SHA-256:
74d07136a35e26b70be2432096396ff8c6a6a43c74a3b6942df3ff908ec0bb02. Previous preview8d62833is retained for rollback. The deployment required no service restart or configuration change.Try the IATA map, configurator, ON/QC proposal or French proposal.
CI blocker: expired content reviews
Run 40958112905 fails content validation because 18 existing pages passed their review deadlines on October 19 or 22. The browser matrix and Lighthouse were consequently skipped; the aggregate browser check fails because those jobs did not run.
The affected English/French pairs are:
meshcore/general-faqresources/linksstart/companion,start/observer,start/repeater,start/room-server,start/verifysubmit-ideatools/indexReview dates and the validator were left unchanged. These pages need a documented content/service review before their verification metadata is renewed and CI is rerun. The October 15 green matrix applies to the earlier
8d62833candidate, not this merge commit.MeshMapper source and rollout safeguards
The integration-key importer, request pacing, private credential-bound cache, partial-country safeguards and review-issue reconciliation remain in place. No key reaches browsers or artifacts. Clean comparisons close only the matching bot-owned review issue while preserving human notes; upstream changes never publish boundaries automatically.
The authenticated October 13 candidate was not promoted because it contained a self-intersecting YQB polygon and a material YUL change. The approved snapshot remains pinned. Recorded findings. Published geometry, planning assignments and observed scope use are not local rollout approval.
Before merge
Production website, submission gateway, brokers and radios were not changed. This PR has not been merged.