Repository navigation
Conversation
…0 release The pinned commit predates Mesh-LLM/mesh-llm#2448, so its build script always runs the bundled protoc, even when PROTOC is set. v0.80.0 has that change and still carries announce_plugin_key (Mesh-LLM/mesh-llm#2299); crates.io has no mesh-llm-plugin past 0.78.1, so the pin stays a git rev (Mesh-LLM#52). The stand-in hosts in tests/ fill the fields protocol 3 gained since (settings_json, invocation_id) as a host without them sends them: empty. Signed-off-by: kleinbem <martin.kleinberger@gmail.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Moves the mesh-llm-plugin pin to the v0.80.0 release commit, as agreed in #52. crates.io still stops at 0.78.1, so it stays a git rev for now and #52 stays open.
The old commit ignores
PROTOC(changed in Mesh-LLM/mesh-llm#2448), so builds with their own protoc had to patch it, like the nixpkgs package I'm adding (NixOS/nixpkgs#583565).Still protocol 3,
min_host_versionstays 0.78.0. Only the test stand-in hosts needed the two new fields, left empty. The lock only moves the mesh-llm crates.Fork CI is green and the two-node e2e passes against 0.79.0. nixpkgs builds it without the patch on x86_64-linux, aarch64-linux and aarch64-darwin.
Summary by CodeRabbit