Repository navigation
feat: Site navigation visibility icons follow the configured icon colour EXO-90340 - #577
Merged
Merged
Conversation
…our EXO-90340 **Why** eXIP 7.3.0.31 US07 (EXO-90340): every icon honours the configured icon colour. The site-navigation icons that still carried a neutral hard-coded colour are rebased on platform-ui's `@iconColor` chain, `var(--appIconColor, var(--allPagesBaseIconColor, <built-in>))`, so they follow the container keys of US02 and US03 and keep the platform grey when none is set. **How** - `NodeItem.vue`: the visibility and access icons lose `color="grey"` and `dark` (which would have painted them white). Left as they are: `disabled--text` on system items, success, error, white and primary icons. Verified: Less compiles and the war builds; deployed on a local server. Knowledge: owed at the `feature/mips` integration PR — the US07 audit's two lessons (a text helper class painting an icon outside the chain, an SVG image used as an icon) go to the eng-standards PR the delivery owes. This change is classified N3: no REST/DAO/schema/ACL surface touched (`classification.md` §3), stylesheet and template changes only; the delivery is N1 by max-severity at the `feature/mips` integration PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
MayTekayaa
added a commit
that referenced
this pull request
Oct 8, 2026
…our EXO-90340 (#577) **Why** eXIP 7.3.0.31 US07 (EXO-90340): every icon honours the configured icon colour. The site-navigation icons that still carried a neutral hard-coded colour are rebased on platform-ui's `@iconColor` chain, `var(--appIconColor, var(--allPagesBaseIconColor, <built-in>))`, so they follow the container keys of US02 and US03 and keep the platform grey when none is set. **How** - `NodeItem.vue`: the visibility and access icons lose `color="grey"` and `dark` (which would have painted them white). Left as they are: `disabled--text` on system items, success, error, white and primary icons. Verified: Less compiles and the war builds; deployed on a local server. Knowledge: owed at the `feature/mips` integration PR — the US07 audit's two lessons (a text helper class painting an icon outside the chain, an SVG image used as an icon) go to the eng-standards PR the delivery owes. This change is classified N3 at c66a3cb: no REST/DAO/schema/ACL surface touched (`classification.md` §3), stylesheet and template changes only; the delivery is N1 by max-severity at the `feature/mips` integration PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 2278e4b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
eXIP 7.3.0.31 US07 (EXO-90340): every icon honours the configured icon colour. The site-navigation icons that still carried a neutral hard-coded colour are rebased on platform-ui's
@iconColorchain,var(--appIconColor, var(--allPagesBaseIconColor, <built-in>)), so they follow the container keys of US02 and US03 and keep the platform grey when none is set.How
NodeItem.vue: the visibility and access icons losecolor="grey"anddark(which would have painted them white).Left as they are:
disabled--texton system items, success, error, white and primary icons.Verified: Less compiles and the war builds; deployed on a local server.
Knowledge: owed at the
feature/mipsintegration PR — the US07 audit's two lessons (a text helper class painting an icon outside the chain, an SVG image used as an icon) go to the eng-standards PR the delivery owes.This change is classified N3 at c66a3cb: no REST/DAO/schema/ACL surface touched (
classification.md§3), stylesheet and template changes only; the delivery is N1 by max-severity at thefeature/mipsintegration PR.🤖 Generated with Claude Code