Repository navigation
Fix trust scoring so healthy homes can earn an A - #65
Merged
Merged
Conversation
…vices Blocked advertising and analytics lookups arrive from the DNS filter flagged as warnings, so they were still being counted as threat-intel matches (-7 each, up to -35) even after they stopped counting as blocked requests. They are now excluded from both factors. A device also could never score above 85, so a perfectly healthy home could never earn an A. Household-authorized devices with no blocked threats, open alerts, or unusually broad activity now get a +10 "clean recent activity" bonus. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WH6rjxMVdiETELosD3ext
The window clause was interpolated into the query with an f-string. It was a constant, but Bandit flags the pattern; write the queries out in full instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WH6rjxMVdiETELosD3ext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two scoring problems made normal households look unhealthy:
Type of change
How Has This Been Tested?
Generated by Claude Code