Repository navigation
fix(country): resilient lookups across transient failures - #27
Merged
Merged
Conversation
Countries refresh at each probe start through the resilient lookup; no separate affordance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Http,Decode) instead of collapsing every failure into a unit error.Why
Subnets could stay stuck without a country when the lookup hit a transient failure window (local DNS intermittently failed to resolve the lookup service). v0.4.0 preserved existing values but nothing re-resolved the missing ones; every Probe now refreshes the scope's countries before speed measurements and survives short outages.
Validation
cargo fmt --check,cargo clippy --locked --all-targets -- -D warnings,cargo test --locked --lib(81 tests)#[ignore]live lookup test of the previously stuck subnetsbun run check,bun run buildGITHUB_REF_NAME=v0.4.1 sh scripts/check-version.sh