Skip to content

ZSTAC-86944: honor API VPC agent upgrade - #4746

Open
zstack-robot-2 wants to merge 1 commit into
5.5.38from
sync/boce.wang/fix-86944@@2
Open

ZSTAC-86944: honor API VPC agent upgrade#4746
zstack-robot-2 wants to merge 1 commit into
5.5.38from
sync/boce.wang/fix-86944@@2

Conversation

@zstack-robot-2

Copy link
Copy Markdown
Collaborator

Jira

http://jira.zstack.io/browse/ZSTAC-86944

Changes

  • Preserve API origin when APIReboot is forwarded as an internal reboot message.
  • Treat explicit APIStart and APIReboot like APIReconnect during grayscale upgrade.
  • Keep internal and HA lifecycle operations under the existing grayscale gate.
  • Add Java unit coverage for API and internal paths.

Verification

  • git diff --check passed.
  • Tests were not run locally; compile and test only on the development machine.

sync from gitlab !10804

Preserve the API origin through reboot message forwarding and let explicit VPC start and reboot operations deploy the current agent during grayscale upgrade. Route VyOS SSH creation through the platform factory so the asynchronous deployment path can be covered by integration tests while production still creates real SSH clients.

Tests: GrayscaleUpgradeCase (development machine).

Resolves: ZSTAC-86944

Change-Id: I6868776cac66e45390b741fa86ecbce1c92df00b
@MatheMatrix
MatheMatrix force-pushed the sync/boce.wang/fix-86944@@2 branch from b1476c5 to 6dd5a9a Compare August 31, 2026 08:10
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 32 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 98 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5ed94749-9b4f-4395-92ff-122f6a0000cc

📥 Commits

Reviewing files that changed from the base of the PR and between 603caaf and 6dd5a9a.

📒 Files selected for processing (4)
  • compute/src/main/java/org/zstack/compute/vm/VmInstanceBase.java
  • header/src/main/java/org/zstack/header/vm/RebootVmInstanceMsg.java
  • plugin/virtualRouterProvider/src/main/java/org/zstack/network/service/virtualrouter/vyos/VyosDeployAgentFlow.java
  • test/src/test/java/org/zstack/network/service/virtualrouter/vyos/VyosDeployAgentFlowTest.java

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation timed out.
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants