Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Deferring private AppKit menu initialization changes launch ordering, and selector-existence tests cannot establish safe launch and menu behavior without runtime validation on supported macOS versions.
No open issues 🎉
What changed in this PR
This PR defers additional low-priority startup work in MarkEdit’s macOS app, postponing AppKit menu setup and editor preloading.
Changes:
- Defer main-menu customization and Open Recent menu installation through
AppDeferredTasks. - Delay editor warm-up by 0.4 seconds for open panels and Quick Search windows.
- Add runtime checks for the private AppKit selectors used by the new hooks.
| File | Description |
|---|---|
| MarkEditMac/Sources/Main/Application/Application.swift | Register the two new menu-deferral hooks. |
| MarkEditMac/Sources/Main/Application/AppDelegate.swift | Delay editor warm-up by 0.4 seconds. |
| MarkEditMac/Sources/Extras/NSDocumentController+Extras.swift | Defer Open Recent menu installation. |
| MarkEditMac/Sources/Extras/NSApplication+Extras.swift | Defer main-menu customization. |
| MarkEditMac/Modules/Tests/RuntimeTests.swift | Check that both hooked AppKit selectors exist. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.