Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused refactor addresses the reported mismatch with targeted regression coverage and no identified blocking issues.
No open issues 🎉
What changed in this PR
Unifies heading-anchor resolution between preview and hidden-syntax navigation, addressing the punctuation mismatch reported in MarkEdit issue #1832.
Changes:
- Adds shared heading-anchor generation and target lookup.
- Uses the shared lookup in preview navigation and heading-line resolution.
- Adds regression coverage for punctuation, Unicode, duplicate headings, and non-heading targets.
| File | Description |
|---|---|
| tests/navigation.test.ts | Tests shared heading resolution and preservation of non-heading targets. |
| tests/frontMatter.test.ts | Updates expected heading HTML for the new anchor attribute. |
| src/render.ts | Registers heading-anchor generation and shares target lookup. |
| src/features/navigation.ts | Uses shared lookup for preview links. |
| src/features/anchors.ts | Implements heading-anchor generation and target resolution. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See MarkEdit-app/MarkEdit#1832.