Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, dependency updates are consistent, and focused regression coverage accompanies the sanitizer isolation with no blocking issues identified.
No open issues 🎉
What changed in this PR
Upgrades DOMPurify and js-yaml while preserving preview rendering and front-matter behavior.
Changes:
- Updates dependency versions and lockfile resolutions.
- Isolates HTML and table widget sanitizers from Mermaid’s shared-instance hooks.
- Adds regression coverage for sanitization, math rendering, and YAML parsing.
| File | Description |
|---|---|
| yarn.lock | Updates and consolidates dependency resolutions. |
| tests/mermaid.integration.test.ts | Checks widget sanitization remains unchanged after rendering Mermaid. |
| tests/hiddenSyntax/table.test.ts | Covers math markup preservation and safe table attributes. |
| tests/hiddenSyntax/html.test.ts | Covers safe attributes and HTML-only sanitization. |
| tests/frontMatter.test.ts | Checks quoted values and body preservation after invalid metadata. |
| tests/frontMatter.parse.test.ts | Extends YAML validation, tag, and alias coverage. |
| src/hiddenSyntax/components/table.ts | Creates an independent table sanitizer instance. |
| src/hiddenSyntax/components/html.ts | Creates an independent HTML sanitizer instance. |
| package.json | Bumps DOMPurify and js-yaml versions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.